Scott Hanselman's Computer Zen - Today's Minor Complaint...

« Code Generation | Main | My quest for the ultimate TabletPC »

Today's Minor Complaint...

Posted 2003-11-06 11:41 AM in XML.

Why is this OK:

using (StringReader sr = new StringReader(response))
{
   try
   {
      retVal = xs.Deserialize(sr);
   }
    //yada yada yada
}

Why and this isnt?

using (XmlTextReader xr = new XmlTextReader(new StringReader(response), /*...yada yada...*/)
{
   try
   {
      retVal = xs.Deserialize(sr);
   }
    //yada yada yada
}

Because StringReaders derive from System.IO.TextReader which implements IDisposable and that's what the using keywords cares about. XmlTextReader derives from the abstract XmlReader, and noone implements IDisposable. I suppose this has something to do with closing streams in the right order, blah blah. Either way, it was a minor sadness today.

Poop.

Thursday, November 06, 2003 2:36:52 PM (Pacific Standard Time, UTC-08:00)

hi scott, what about this:

using System;
using System.Xml;

class DisposableXmlTextReader : XmlTextReader, IDisposable {
public void Dispose() {
base.Close();
}
}

I bet the formatting is going to get beaten up, but you get the idea. XmlTextReader is not sealed, so this should work. Or should it?

Ben

Friday, November 07, 2003 4:09:49 AM (Pacific Standard Time, UTC-08:00)

That's a bit too far I think. Perhaps this is cleaner:

using (StringReader s = new StringReader(response))
{
XmlTextReader xr = new XmlTextReader(s);

...
}

You don't care about IDisposable on XmlTextReader if all you want is the StringReader to be ditched properly.

Dave

Dave Van den Eynde

Saturday, November 08, 2003 1:06:14 PM (Pacific Standard Time, UTC-08:00)

True on both counts...I was just complaining basically that anything that was a "Reader" wasn't Disposable...I've gotten REALLY used to using the "using" keyword, and I prefer it over explicit close() calls.

Of course, I don't care so much as to make a separate derived class, but thanks for the thoughts! :)

Scott Hanselman

Tuesday, November 11, 2003 11:20:13 PM (Pacific Standard Time, UTC-08:00)

FYI, I'm PM for XmlReader, and this was an oversight and is fixed in v2. If you have PDC bits, I believe that copy of frameworks already has the fix -- obviously you would not use this for production work, but the point is we are aware of the problem and are fixing it in v.Next. Thanks!

Joshua Allen

Thursday, February 16, 2006 2:51:16 PM (Pacific Standard Time, UTC-08:00)

Just found your post while googling for the reason why this wasn't implemented. I'm using V2 and it's definitely NOT fixed in V2. So I had to implement this:

def auto_close(obj)
yield obj if block_given?
obj.Close
end

...

auto_close(XmlTextReader.new(path)) do |r|
while r.Read
puts r.LocalName if r.NodeType == XmlNodeType::Element
end
end

Isn't Ruby great? :)